[Webkit-unassigned] [Bug 40162] Prevent Geolocation making callbacks to a ScriptExecutionContext that no longer exists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 06:59:29 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40162





--- Comment #4 from Jeremy Orlow <jorlow at chromium.org>  2010-06-04 06:59:27 PST ---
(From update of attachment 57865)
nm...see the files now..not sure what happened

As discussed, I think this is a nice, simple fix that'd be good for release branches and such, so we should put it in.  But then you should look closer at the current behavior and why it was done this way.  I'm pretty sure that what it currently does is wrong and should be changed.LayoutTests/fast/dom/Geolocation/script-tests/callback-to-deleted-context.js:12
 +      }, 100);
This seems like a recipe for flake.

LayoutTests/fast/dom/Geolocation/script-tests/callback-to-deleted-context.js:10
 +          testPassed('No callbacks invoked');
How do you know that?

LayoutTests/fast/dom/Geolocation/script-tests/callback-to-deleted-context.js:4
 +      iframe.src = 'resources/callback-to-deleted-context-inner2.html';
Isn't this a race?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list