[Webkit-unassigned] [Bug 40158] ASSERTION FAILED with -webkit-appearance:progress-bar for non-progress bar elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 03:33:24 PDT 2010


--- Comment #12 from MORITA Hajime <morrita at google.com>  2010-06-04 03:33:23 PST ---
Hi Kent-san, Thank you for your quick review!

> (From update of attachment 57855 [details])
> LayoutTests/fast/css/script-tests/invalid-appearance-progress-bar-meter.js:3
>  +  var body = document.getElementsByTagName("body")[0];
> document.body is simpler.

> WebCore/rendering/RenderTheme.cpp:47
>  +  #import "RenderProgress.h"
> Why #import instead of #include ?
Just copied from .mm file and didn't noticed. I'm sorry for confusion.

> WebCore/rendering/RenderTheme.h:245
>  +      virtual bool paintMeter(RenderMeter*, const RenderObject::PaintInfo&, const IntRect&);
> For consistency with other paint*() member functions, I prefer not changing the parameter types, and check isMeter() and isProgress() in their paint*() functions.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list