[Webkit-unassigned] [Bug 40158] ASSERTION FAILED with -webkit-appearance:progress-bar for non-progress bar elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40158


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57855|review?                     |review-
               Flag|                            |




--- Comment #8 from Kent Tamura <tkent at chromium.org>  2010-06-04 02:32:20 PST ---
(From update of attachment 57855)
LayoutTests/fast/css/script-tests/invalid-appearance-progress-bar-meter.js:3
 +  var body = document.getElementsByTagName("body")[0];
document.body is simpler.


WebCore/rendering/RenderTheme.cpp:47
 +  #import "RenderProgress.h"
Why #import instead of #include ?


WebCore/rendering/RenderTheme.h:245
 +      virtual bool paintMeter(RenderMeter*, const RenderObject::PaintInfo&, const IntRect&);
For consistency with other paint*() member functions, I prefer not changing the parameter types, and check isMeter() and isProgress() in their paint*() functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.