[Webkit-unassigned] [Bug 16183] SVG doesn't support rgba colors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16183





--- Comment #8 from Dirk Schulze <krit at webkit.org>  2010-06-04 01:08:12 PST ---
(In reply to comment #7)
> Created an attachment (id=57815)
 --> (https://bugs.webkit.org/attachment.cgi?id=57815) [details]
> Patch removing the blocks on hsl, hsla and rgba color specifications from SVG parsing
> 
> Updated patch with hsl and hsla test added.  Extraneous comments describing the change removed from the code

Not sure why you changed the style of the ChangeLog's?!? Can you please update the patch and follow the prevered style of a ChangeLog? That means original bug report title, link to the bug, description if your changes and added Tests at the end? You can also use WebKitTools/Scripts/prepare-ChangeLog --bug 16183. That helps to create a reasonable ChangeLog.
If you're on it, can you explain the context a bit more? Say that the Spec normally uses CSS2, but that we also provide colors in the way of CSS3, that we also follow other browser vendors with this change and so on. I already wrote it in the last review, but can you also delete the comment in SVGColor?: // hsl, hsla and rgba are not in the SVG spec.

To the tests: Why do you test stroke? Wouldn't it be more sensible to test fill? The problem is, that with stroke the tolerance level on pixel tests may not get crossed on wrong code changes. Pixeltest ignore changes that are lower than 0.1%, this can cause regressions that noone recognize.

There is still something wrong with your binarys. The pixel test results are still not in the patch. Can you take a look at it again?

Patch still looks great! I hope you take the suggestions into account and upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.