[Webkit-unassigned] [Bug 39417] Autoscroll should be available on fullscreen view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39417





--- Comment #14 from Tony Chang (Google) <tony at chromium.org>  2010-06-03 20:35:31 PST ---
(From update of attachment 56976)
> +++ b/LayoutTests/fast/events/autoscroll-border-margin-horizontal-body.html
> +                    var endY = startY;
> +                    eventSender.mouseMoveTo(endX, endY);
> +                }
> +
> +                setTimeout(afterDragging, 1000);

Is it possible to avoid this timeout (maybe by using eventSender.leapFoward)?  Is there an event we can get instead?  Or maybe we can poll every 50ms to check for changes?

Also, is it possible to merge some or all of these tests into the same .html file?

> diff --git a/WebCore/page/Settings.h b/WebCore/page/Settings.h
> index dc3b50fb7ad8e423733754deb6ecf03974ef29e6..cc9f35780219435e9d3bc2a2e8252c84b8f35097 100644
> --- a/WebCore/page/Settings.h
> +++ b/WebCore/page/Settings.h
> @@ -311,6 +311,9 @@ namespace WebCore {
>          void setHTML5ParserEnabled(bool flag) { m_html5ParserEnabled = flag; }
>          bool html5ParserEnabled() const { return m_html5ParserEnabled; }
>  
> +        void setAutoscrollBorderMargin(unsigned value) { m_autoscrollBorderMargin = value; }
> +        unsigned autoscrollBorderMargin() const { return m_autoscrollBorderMargin; }
> +

I don't know if this should be a setting or not.  For example, the minimum drag distances (hysteresis) are hard coded in EventHandler.cpp.  I bet this is a platform specific value.

> --- a/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h
> +++ b/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h
> @@ -187,6 +187,8 @@ public slots:
>      */
>      void setScrollbarPolicy(const QString& orientation, const QString& policy);
>  
> +    void setautoscrollbordermargin(unsigned);
> +

This being in lowercase is probably causing the QT bot to be red.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.