[Webkit-unassigned] [Bug 39417] Autoscroll should be available on fullscreen view

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 19:40:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39417





--- Comment #13 from Peter Kasting <pkasting at google.com>  2010-06-03 19:40:57 PST ---
(From update of attachment 56976)
> --- a/WebCore/platform/graphics/IntRect.h
> +++ b/WebCore/platform/graphics/IntRect.h
> @@ -136,6 +136,29 @@ public:
>          m_size.setHeight(m_size.height() + dy + dy);
>      }
>      void inflate(int d) { inflateX(d); inflateY(d); }
> +
> +    void deflateX(int dx)
> +    {
> +        m_location.setX(m_location.x() + dx);
> +        if (dx + dx < m_size.width())
> +            m_size.setWidth(m_size.width() - (dx + dx));
> +        else
> +            m_size.setWidth(0);
> +    }
> +    void deflateY(int dy)
> +    {
> +        m_location.setY(m_location.y() + dy);
> +        if (dy + dy < m_size.height())
> +            m_size.setHeight(m_size.height() - (dy + dy));
> +        else
> +            m_size.setHeight(0);
> +    }
> +    void deflate(int d)
> +    {
> +        deflateX(d);
> +        deflateY(d);
> +    }

It seems like instead of adding these, it might be better to use the existing inflate() functions, and have IntSize::set{Width,Height}() clamp the minimum size to zero.

However, you'd have to make sure we don't actually rely on negative sizes anywhere.  (It seems like a bug if we do.)  Might want to run this idea past Darin Adler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list