[Webkit-unassigned] [Bug 39725] [Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 19:01:13 PDT 2010


--- Comment #14 from MORITA Hajime <morrita at google.com>  2010-06-03 19:01:12 PST ---
Hi Jian, thank you for reviewing again!
The patch landing with fix you suggested.

> WebKit/chromium/public/WebView.h:172
>  +      // Notifies the WebView that a dragging is going on.
> dragging => drag

> WebKit/chromium/src/WebViewImpl.cpp:845
>  +      // This margin approximates Safari behavior
> Please end the sentence with period.
> WebKit/chromium/src/WebViewImpl.cpp:828
>  +  // Computes disatances from a point to the nearest point from a rect for both x and y coordinates.
> I think what Darin suggested for the comment is easy to understand. We have "the distance" represented by a pair of values, not "distances".
Done. I'm sorry that I missed this line....

> WebKit/chromium/src/WebViewImpl.cpp:846
>  +      static const int scrollMargin = 30;
> Please comment why you pick 30. Maybe you could say that this is based on the observation of ...

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list