[Webkit-unassigned] [Bug 39994] Geolocation LayoutTests should make more careful use of LayoutTestController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 15:13:17 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |dumi at chromium.org

--- Comment #3 from Dumitru Daniliuc <dumi at chromium.org>  2010-06-03 15:13:17 PST ---
LGTM, but i have an unrelated question about the .js files in fast/dom/Geolocation/script-tests/. lots of them seem to have code that looks like this:

}, function(e) {
    error = e
    shouldBe('error.code', 'mockCode');
    shouldBe('error.message', 'mockMessage');

shouldn't there be a ';' after 'error = e' (at least from a style point of view)?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list