[Webkit-unassigned] [Bug 40134] Web Inspector: sendMessageToFrontend implementation required.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40134





--- Comment #5 from Ilya Tikhonovsky <loislo at chromium.org>  2010-06-03 14:09:48 PST ---
(In reply to comment #4)
> (From update of attachment 57799 [details])
> > +++ b/WebCore/inspector/InspectorFrontend.cpp
> > +InspectorFrontend::InspectorFrontend(ScriptObject webInspector, InspectorClient* inspectorClient)
> > +    : m_webInspector(webInspector), m_inspectorClient(inspectorClient)
> 
> I think the usual style for this is:
> 
>     : m_a(a)
>     , m_b(b)

ok

> > -  ASSERT(frontend);
> 
> Should we change this to ASSERT(webInspector)? Or will this be
> expected to handle a case of a null ScriptCobject.

as far as it is transfered by ref we don't need to check that.


> > +++ b/WebCore/inspector/InspectorFrontend.h
> > +#include <wtf/RefPtr.h>
> > ...
> > +        void addRecordToTimeline(const RefPtr<InspectorObject>&);
> 
> Is this used in this patch? If not, I would say leave this out
> for the next patch.

Already fixed this in the second iteration.


> > +        InspectorClient* m_inspectorClient;
> 
> Likewise this is added and included in the constructor above
> but it isn't used yet. I have an idea how it will be used, but
> I think before this patch lands there should be another patch
> showing an example usage, even if its trivial.

I'm trying to keep the patches small and  the next patches will 
use m_inspectorClient for the real transfer data.
As result I think we don't need a special example of usage.

> > +++ b/WebCore/inspector/InspectorClient.h
> > + virtual bool sendMessageToFrontend(const String& message) = 0;
> 
> It might be worth mentioning what the bool return value here
> means. If not a comment then certainly something in the ChangeLog.

ok.

> Great work on this so far!

thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.