[Webkit-unassigned] [Bug 39725] [Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39725


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57729|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Jian Li <jianli at chromium.org>  2010-06-03 13:48:30 PST ---
(From update of attachment 57729)
Looks good except some minor issues. Please land it with these issues addressed.

WebKit/chromium/public/WebView.h:172
 +      // Notifies the WebView that a dragging is going on.
dragging => drag

WebKit/chromium/src/WebViewImpl.cpp:845
 +      // This margin approximates Safari behavior
Please end the sentence with period.

WebKit/chromium/src/WebViewImpl.cpp:828
 +  // Computes disatances from a point to the nearest point from a rect for both x and y coordinates.
I think what Darin suggested for the comment is easy to understand. We have "the distance" represented by a pair of values, not "distances".

WebKit/chromium/src/WebViewImpl.cpp:846
 +      static const int scrollMargin = 30;
Please comment why you pick 30. Maybe you could say that this is based on the observation of ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.