[Webkit-unassigned] [Bug 40103] ThreadingPthread create thread with default stack size which might not be enough

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40103





--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2010-06-03 13:09:34 PST ---
> This patch is needed for any platform that use pthread and its pthread_create()
> uses too small stack size that it will cause stack overflow. For me 64 * 1024 is fine so far.

I don't think that this answers all of the questions I posted. I don't ask for complete explanations of things like "how do I choose stack size", but some information for developers who later look at this code would help a lot (with the current patch, someone refactoring this code would likely just delete this part as dead code).

JavaScriptCore limits call depth (for calls that use native stack), and that limit is adjustable. Are you talking about stack overflow in JS code, or in some other code? Can this be resolved by adjusting JS call depth for your platform instead?

> This is not what I planned to do, but without this change the coding style checked
> failed my patch, as what it did to my first patch.

You should feel free to ignore style bot complaints if it's complaining about code you didn't change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.