[Webkit-unassigned] [Bug 38156] many webkit-patch commands fail in a non-svn tracking git checkout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38156





--- Comment #15 from Ojan Vafai <ojan at chromium.org>  2010-06-03 13:08:21 PST ---
(In reply to comment #14)
> (In reply to comment #12)
> > > Question: do all git commands also accept a fully-qualified reference path (i.e.
> > > branch "ref") wherever a simple branch name is accepted?
> > 
> > No. git branch -D fails if you give it a reference. That's the only case I've found so far that doesn't accept a reference.
> 
> From the below, it looks like it accepts a reference.  Perhaps what you meant is that it only accepts branch references (and not, say, remote-tracking references).

Nope. We're only passing the branch_name to git branch. We pass the reference to _branch_ref_exists. If you pass the reference to git branch, you get an error.

> > +    def delete_branch(self, branch_name):
> > +        if self._branch_ref_exists('refs/heads/' + branch_name):
> > +            self.run(['git', 'branch', '-D', branch_name])

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.