[Webkit-unassigned] [Bug 40129] Geolocation needs LayoutTest to test making callbacks to remote frames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40129





--- Comment #7 from Jeremy Orlow <jorlow at chromium.org>  2010-06-03 11:12:47 PST ---
(In reply to comment #4)
> (From update of attachment 57787 [details])
> I don't think that tests like this should be script-tests. That doesn't improve anything, but has very real costs - for example, I can't just open a test and see what it does, as I need to open related .js file in a subdirectory instead.
> 
> Also, it's more difficult to share tests that utilize complicated support libraries with engineers working on other engines, so it's less likely that they will run our tests and be compatible with us.

If you feel strongly about this, we should probably start a webkit-dev thread on the subject.  Because most other reviewers I know prefer doing tests like this with script-tests and factoring out as much code as possible into support libraries.  (I actually didn't realize that anyone was advocating keeping them independent and such.  I definitely agree there are some merits to doing so, but I think there are more benefits to keeping tests compact and easy to read.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.