[Webkit-unassigned] [Bug 40064] Web Inspector: Implement JSON parsing for InspectorValue.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 06:55:51 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40064





--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2010-06-03 06:55:51 PST ---
(From update of attachment 57761)
Function names should start with lower case.

WebCore/inspector/InspectorValues.cpp:40
 +  static const int kStackLimit = 100;
1000 ?

WebCore/inspector/InspectorValues.cpp:40
 +  static const int kStackLimit = 100;
no k prefix, start from capital.

WebCore/inspector/InspectorValues.cpp:57
 +  const char* const kNullString = "null";
no k prefix here and below.

WebCore/inspector/InspectorValues.cpp:63
 +      while (start < end && *token != '\0' && *start++ == *token++) {
{ } on same line.

Overall looks good. Please make the code conform to the WebKit style guidelines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list