[Webkit-unassigned] [Bug 21937] h1:first-letter is incorrectly inherited by run-in box

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21937





--- Comment #7 from Yoshiki Hayashi <yhayashi at google.com>  2010-06-03 03:25:25 PST ---
Thank you for review!

(In reply to comment #6)
> (From update of attachment 57313 [details])
> Looks good, but putting r- for minor issues.
> 
> I've noticed that with the following HTML
> 
> <style type="text/css">
>   h1:first-letter {text-transform: uppercase;}
> </style>
> <h1 style="display:run-in;">capitalized</h1><div>downcase</div>
> 
> the text "capitalized" isn't capitalized even with this patch. Is this issue related to this bug? Or, should we file another bug to resolve this issue?

That's a different bug.  Right now, WebKit doesn't apply first-letter to inline elements.  In this case, the h1 with run-in is converted to an inline element and inserted as the first element of the div so it won't get :first-letter.  The following link shows that div gets :first-letter while span does not.

http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cstyle%3E%0Adiv%3A%3Afirst-letter%20%7B%0A%20%20text-transform%3A%20uppercase%3B%0A%7D%0Aspan%3A%3Afirst-letter%20%7B%0A%20%20text-transform%3A%20uppercase%3B%0A%7D%0A%3C%2Fstyle%3E%0A%0A%3Cdiv%3E%0Atest%0A%3C%2Fdiv%3E%0A%0A%3Cspan%3E%0Atest%0A%3C%2Fspan%3E%0A&ohh=1&ohj=1&jt=&ojh=1&ojj=1&ms=100&oth=0&otj=0&cex=1

> 
> I think this patch depends on the patch in Bug 39863 so we should not land this patch without fixing Bug 39863. For such cases, please set commit-queue- to tell reviewers/committers that this patch should not be landed.
> 
> 
> LayoutTests/ChangeLog:8
>  +          Need a short description and bug URL (OOPS!)
> This line should be gone.
> 
> WebCore/ChangeLog:8
>  +          Need a short description and bug URL (OOPS!)
> Unnecessary. Or, you might want to describe something.

Oops.  Removed.

> LayoutTests/fast/css/first-letter-after-run-in.html:18
>  +  <div class="run-in">run-in</div><div class="upper">test</div>
> I would say
> 
> <div class="run-in">not-capitalized</div><div class="upper">capitalized</div>
> 
> or something like this so we can remove the description about the expectation ("If you see...")

Done.

I also added a test case where run-in stays as a block level element and if :first-letter gets applied to that element.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.