[Webkit-unassigned] [Bug 40080] Web Inspector: better Function.prototype.bind for the internal code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 03:11:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40080


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57700|review+                     |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-06-03 03:11:54 PST ---
(From update of attachment 57700)
Clearing r+ since Nikita won't be able to land it with modifications anyways (he is not yet a committer).

WebCore/inspector/front-end/utilities.js:58
 +      function bound() {
Please move { to the next line.


Also, I am not a fan of this change - it improves things for Web Inspector, but leaves rest of the web developers suffering. None of the major frameworks do this trick for the bind.
In fact, there already is something that could become a standard: see https://bugs.webkit.org/show_bug.cgi?id=25171. I don't like it much, but it is already there. I'd rather support displayName in event listeners list and set in bind to be consistent.

Ideal solution to my taste is when we infer the name from the closure. It is hard though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list