[Webkit-unassigned] [Bug 37310] [Chromium] Support HTML5 <progress> element on Linux.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37310





--- Comment #8 from MORITA Hajime <morrita at google.com>  2010-06-02 17:55:40 PST ---
Hi Kent-san, thank you for reviewing!
I updated the patch.

(In reply to comment #6)
> (From update of attachment 57630 [details])
> WebCore/rendering/RenderThemeChromiumSkia.cpp:775
>  +  static const int progressDeltaPixelsPerSecond = 100;
> Please add comments about how did you determine these values.
Added comment.

> WebCore/rendering/RenderThemeChromiumSkia.cpp:810
>  +      return progressAnimationInterval*progressAnimationFrmaes*2; // "2" for back and forth
> Add spaces around *.
Done.

> 
> 
> WebCore/rendering/RenderThemeChromiumSkia.cpp:826
>  +      paintInfo.context->drawTiledImage(barImage, renderObject->style()->colorSpace(), rect, IntPoint(0, 0), barTileSize);
> We had better assign renderObject->style()->colorSpace() to a variable because it is used multiple times.
Done.

> 
> 
> WebCore/rendering/RenderThemeChromiumSkia.h:126
>  +          IntRect determinateProgressValueRectFor(RenderProgress*, const IntRect&) const;
> We should make these internal functions to private or protected.
Moved to protected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.