[Webkit-unassigned] [Bug 39282] Slave lost shouldn't be recognized as build failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39282





--- Comment #7 from Csaba Osztrogonac <ossy at webkit.org>  2010-06-02 08:46:28 PST ---
(In reply to comment #6)
> Created an attachment (id=57659)
 --> (https://bugs.webkit.org/attachment.cgi?id=57659) [details]
> Patch

Here is the fixed patch with unit test for slave lost.
I have to add a "not not", because False or None == None.
Or is there any simple way to fix this problem?

Error message why I had to roll-out my earlier patch:

Traceback (most recent call last):
  File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py", line 218, in test_status_parsing
    self.assertEquals(builder[key], expected_value, ("Builder %d parse failure for key: %s: Actual='%s' Expected='%s'" % (x, key, builder[key], expected_value)))
AssertionError: Builder 2 parse failure for key: is_green: Actual='None' Expected='False'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.