[Webkit-unassigned] [Bug 39953] Web Inspector: support "Continue to Here" in debugger
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 2 07:49:38 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=39953
Pavel Feldman <pfeldman at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #57651|review? |review+
Flag| |
--- Comment #5 from Pavel Feldman <pfeldman at chromium.org> 2010-06-02 07:49:36 PST ---
(From update of attachment 57651)
Overall, this looks good, so I am open to landing this. However, the change uncovers some problems with our design in the area of passing numerous callbacks into SourceFrame.
As we discussed offline, I would suggest the following refactorings:
1. Make SourceFrame BreakpointManager's listener
1.1. Make SourceFrame responsible for filling breakpoints on creation (few addBreakpoint snippets will go away from ScriptsPanel)
2. Remove sourceFrameForScriptOrResource from the scripts panel.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list