[Webkit-unassigned] [Bug 37310] [Chromium] Support HTML5 <progress> element on Linux.

Wed Jun 2 06:58:55 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37310

Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57630|review?                     |review-
               Flag|                            |

--- Comment #6 from Kent Tamura <tkent at chromium.org>  2010-06-02 06:58:55 PST ---
(From update of attachment 57630)
WebCore/rendering/RenderThemeChromiumSkia.cpp:775
 +  static const int progressDeltaPixelsPerSecond = 100;
Please add comments about how did you determine these values.

WebCore/rendering/RenderThemeChromiumSkia.cpp:810
 +      return progressAnimationInterval*progressAnimationFrmaes*2; // "2" for back and forth
Add spaces around *.

WebCore/rendering/RenderThemeChromiumSkia.cpp:826
 +      paintInfo.context->drawTiledImage(barImage, renderObject->style()->colorSpace(), rect, IntPoint(0, 0), barTileSize);
We had better assign renderObject->style()->colorSpace() to a variable because it is used multiple times.

WebCore/rendering/RenderThemeChromiumSkia.h:126
 +          IntRect determinateProgressValueRectFor(RenderProgress*, const IntRect&) const;
We should make these internal functions to private or protected.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.