[Webkit-unassigned] [Bug 39588] Provide implementation of DeviceOrientation and hook into DOMWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39588





--- Comment #5 from Steve Block <steveblock at google.com>  2010-06-02 06:11:41 PST ---
> Drive by comments (I'm not qualified to review this):
Can you recommend somebody who could review it?

> WebCore/page/DOMWindow.cpp:1396
>  +      if (eventType == eventNames().deviceorientationEvent && frame() && frame()->page())
> maybe this should be an else if joined with the previous block?
Done

> WebCore/dom/DeviceOrientation.cpp:45
>  +      ASSERT(!m_listeners.contains(window));
> If you add multiple event listeners to one window, does it call
> addEventListener multiple times?  I would have thought so...in which case, this
> assumption wouldn't be true.
Fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.