[Webkit-unassigned] [Bug 40046] Compilation error when you disable DRAG SUPPORT.

Wed Jun 2 00:59:11 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40046

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57629|review?                     |review-
               Flag|                            |

--- Comment #2 from David Levin <levin at chromium.org>  2010-06-02 00:59:11 PST ---
(From update of attachment 57629)
> 2010-06-02  Deepak Mundra  <deepak.m at allaboutif.com>
> 
>         Reviewed by NOBODY (OOPS!).
> 
>         Fix compilation, when you disable DRAG SUPPORT.
>         ENABLE(DRAG_SUPPORT) wrappers were missing in WebCore/page/gtk/EventHandlerGtk.cpp.

The general idea looks great, but this patch isn't well formed, so it doesn't apply on the bots and it wouldn't go through using the commit queue.

It looks like you may have a ChangeLog but the file that it applies to is not in the patch. If you need help preparing your patch, please see http://webkit.org/coding/contributing.html.

Note that this ChangeLog is missing a *bug link* which is also typical for ChangeLog entries.

when you put the patch up for review again, consider marking it commit-queue? so that the reviewer will also mark it as commit-queue+ and it will get committed for you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.