[Webkit-unassigned] [Bug 40009] [Gtk] Make DRT more coherent with other ports to allow reusing more tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40009





--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2010-06-01 14:28:13 PST ---
(In reply to comment #2)
> (From update of attachment 57569 [details])
> I like this approach a lot better!
> 
> > -    return JSStringCreateWithUTF8CString(atk_role_get_name(role));
> > +    const gchar* roleName = atk_role_get_name(role);
> > +    GOwnPtr<gchar> axRole(g_strdup_printf("AXRole: %s", roleName));
> > +
> > +    return JSStringCreateWithUTF8CString(axRole.get());
> >  }
> 
> Only one small nit. You don't need roleName here. You can simply
> use atk_role_get_name(...) in g_strdup_printf.

Yeah, I know. Just did it that way to avoid having a too long line. But I can make the change if that fits better in WebKit codebase, no problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.