[Webkit-unassigned] [Bug 39998] Notification object ref counting is not correct.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 13:33:02 PDT 2010


--- Comment #3 from Darin Adler <darin at apple.com>  2010-06-01 13:33:00 PST ---
(From update of attachment 57551)
> -        Notification* createHTMLNotification(const String& URI, ExceptionCode& ec)
> +        PassRefPtr<Notification> createHTMLNotification(const String& URI, ExceptionCode& ec)

This change is great.

> -            return Notification::create(m_scriptExecutionContext->completeURL(URI), context(), ec, presenter());
> +            return adoptRef(Notification::create(m_scriptExecutionContext->completeURL(URI), context(), ec, presenter()));

This seems wrong. The adoptRef should be inside Notification::create and it should return a PassRefPtr!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list