[Webkit-unassigned] [Bug 39639] [Chromium] Implement new PopupMenuClient methods for AutoFill.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39639





--- Comment #3 from James Hawkins <jhawkins at chromium.org>  2010-06-01 13:26:38 PST ---
(In reply to comment #2)
> (From update of attachment 56959 [details])
> WebCore/rendering/RenderMenuList.h:104
> > +      virtual void selectionChanged(unsigned, bool) {}
> nit: please give these parameters some names.  the type names alone
> do not adequately describe their purpose.
> 

Done.

> WebCore/rendering/RenderTextControlSingleLine.h:111
> > +      virtual void selectionChanged(unsigned, bool) {}
> nit: please give these parameters some names.  the type names alone
> do not adequately describe their purpose.
> 

Done.

> WebKit/chromium/src/AutoFillPopupMenuClient.cpp:102
>  +      // FIXME: Refactor this method.
> nit: please be a bit more descriptive with this comment.  if someone else
> is reading this, it'd be great to not have to guess what you had in mind.
> i'm not sure what you intend to refactor ;-)
> 

Done.

> WebKit/chromium/src/SuggestionsPopupMenuClient.h:64
>  +      virtual void selectionChanged(unsigned, bool) {}
> nit: please give these parameters some names...
> 
> otherwise, LGTM.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.