[Webkit-unassigned] [Bug 40009] [Gtk] Make DRT more coherent with other ports to allow reusing more tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 1 11:53:11 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=40009
--- Comment #2 from Martin Robinson <mrobinson at webkit.org> 2010-06-01 11:53:11 PST ---
(From update of attachment 57569)
I like this approach a lot better!
> - return JSStringCreateWithUTF8CString(atk_role_get_name(role));
> + const gchar* roleName = atk_role_get_name(role);
> + GOwnPtr<gchar> axRole(g_strdup_printf("AXRole: %s", roleName));
> +
> + return JSStringCreateWithUTF8CString(axRole.get());
> }
Only one small nit. You don't need roleName here. You can simply
use atk_role_get_name(...) in g_strdup_printf.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list