[Webkit-unassigned] [Bug 40003] New: [Qt] Fix the lifecycle of notification objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 09:20:13 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40003

           Summary: [Qt] Fix the lifecycle of notification objects
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yael.aharon at nokia.com
                CC: hausmann at webkit.org
            Blocks: 39995


Notification objects are not tightly related to the page that created them, and should be decoupled from the page.

- Create one NotificationPresenter that handles all notifications.
- Add ref/deref to the notification objects when they are added/removed from the queue of active notifications. The same technique is used for XMLHttpRequest.
- Instead of deleting all notifications associated with a page when the page is navigated, delete them on a timer, using the same timeout that QSystemTrayIcon is using.
- Break up the show() method into smaller methods.
- Use OwnPtr instead of raw pointer for QSystemTrayIcon.
- Move creating the QIcon to just before showing it in the QSyetemTrayIcon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list