[Webkit-unassigned] [Bug 43276] Implements IDBKeyPath extractor.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 16:15:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43276


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-07-30 16:15:32 PST ---
Attachment 63117 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/tests/IDBKeyPathExtractorTest.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebKit/chromium/tests/IDBKeyPathExtractorTest.cpp:67:  Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b)  [readability/check] [2]
WebKit/chromium/tests/IDBKeyPathExtractorTest.cpp:84:  Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b)  [readability/check] [2]
WebKit/chromium/tests/IDBKeyPathExtractorTest.cpp:99:  Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b)  [readability/check] [2]
WebKit/chromium/tests/IDBKeyPathExtractorTest.cpp:100:  Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b)  [readability/check] [2]
WebKit/chromium/tests/IDBKeyPathExtractorTest.cpp:119:  Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b)  [readability/check] [2]
Total errors found: 6 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list