[Webkit-unassigned] [Bug 43254] Expand SVG Attribute Macros

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43254


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63067|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-07-30 09:57:33 PST ---
(From update of attachment 63067)
I'll pick on you, but only because you're new here! :P

WebCore/ChangeLog:10
 +          No new tests.
Why no new test?

Usually a simple explanation is provided, like:

"No change in behavior, so no new tests."

WebCore/ChangeLog:130
 +          * rendering/style/SVGRenderStyleDefs.h:
This long list of changes is not very useful. Typically, the author of the ChangeLog takes this produced template and makes something useful out of it, like:

rendering/style/SVGRenderStyle.h: Expanded and removed references to <list of macros> macros.
rendering/style/SVGRenderStyleDefs.h: Removed definitons for expanded macros.

Then you can zap the rest of the list in the template.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.