[Webkit-unassigned] [Bug 25645] SVG - numeric overflow for very large elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25645


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62940|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #68 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-30 08:36:34 PST ---
(From update of attachment 62940)
r-, ChangeLogs are missing. And some additional issues:

WebCore/svg/SVGParserUtilities.cpp:70
 +        ++ptr; // Advance to first non-digit.
Four-spaces indention please.

WebCore/svg/SVGParserUtilities.cpp:73
 +        const UChar* ptrScanIntPart = ptr - 1;
Ditto.

WebCore/svg/SVGParserUtilities.cpp:76
 +          integer = integer + multiplier * static_cast<FloatType>(*(ptrScanIntPart--) - '0');
Ditto. And you can use integer += multipler * ... here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.