[Webkit-unassigned] [Bug 43249] [Qt] WebKit2 build system cannot handle generated headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43249


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63056|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2010-07-30 07:04:31 PST ---
(From update of attachment 63056)
I'm going to say r- because of the other suggested approach. If you still want to use this approach, then I think at least the addExtraCompiler duplication should be replaced with a direct use of QMAKE_EXTRA_COMPILERS, as I don't think any of these copy steps use any of the features that addExtraCompiler() adds to the regular qmake extra compiler handler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.