[Webkit-unassigned] [Bug 42603] Add a mock in WebCore for testing speech input

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42603


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62977|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Jeremy Orlow <jorlow at chromium.org>  2010-07-30 03:50:12 PST ---
(From update of attachment 62977)
WebCore/platform/mock/SpeechInputClientMock.cpp:34
 +  #include "SpeechInputListener.h"
put inside the #if ENABLE()  (from now on)

WebCore/platform/mock/SpeechInputClientMock.cpp:53
 +      m_timer.startOneShot(0.1);
Why the delay?  Normally we do with 0 delay to make it harder to have flaky tests.

WebCore/platform/mock/SpeechInputClientMock.cpp:85
 +          m_timer.startOneShot(0.1);
ditto


r=me
please make just the changes I mentioned and then I'll rubber stamp that + commit queue it

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.