[Webkit-unassigned] [Bug 43180] Change permission to access methods in XMLDocumentParser.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43180





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-07-30 03:22:58 PST ---
(In reply to comment #2)
> (From update of attachment 62928 [details])
> This is not the right fix. If we have to make these public we will, but we should not use conditionals.
> 
> Where is the code in WML that uses these? Why is it using an XMLDocumentParser* instead of a DocumentParser*?

The reportWMLError() of WMLErrorHandling.cpp is using these functions. It seems that the accessibility was changed by Bug 41114 - Start to clean up DocumentParser interface. But, there are no the reasons in the bug.

Frankly, I don't know why this WMLErrorHandling.cpp uses XMLDocumentParser.cpp yet. I am trying to trace the reason via log.

I suspects that WML guys uses XMLDocumentParser to handle error via these functions.

In my opinion, there are two solutions. One is we change these functions's accessibility with public. As you said, other is that we don't use XMLDocumentParser in WMLErrorHandling.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.