[Webkit-unassigned] [Bug 39589] Add LayoutTestController methods to test DeviceOrientation

Fri Jul 30 02:56:30 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39589

--- Comment #38 from hans at chromium.org  2010-07-30 02:56:29 PST ---
(In reply to comment #36)
> Steve:
> 
> This is causing a lot of problems for us in Chromium land.  I know it's not really procedure since this didn't break anything on an official builder, but I think (hope) you won't mind if we revert this temporarily reverting this.
> 
> Hans: in a local Chromium client, please revert the revert (git revert <the change>) and run the ui tests and unit tests.  It's probably easy fixes, but I'm not sure what to do for now.
> 
> Steve, we'll try to make sure this gets back in tomorrow or we'll just disable device orientation in Chromium for now.

The problem in Chromium is that for some code paths, the runtime flag for device orientation is accidentally left on even though no DeviceOrientationClient is provided.

Creating Bug 43237 to explicitly set the flag to off in chromium until we have a proper implementation.

After that is landed, this patch should be re-landed.

Sorry for the inconvenience.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.