[Webkit-unassigned] [Bug 40092] spellcheck does not check pasted text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40092


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61488|0                           |1
        is obsolete|                            |
  Attachment #63034|                            |review?
               Flag|                            |




--- Comment #14 from Hironori Bono <hbono at chromium.org>  2010-07-30 00:27:11 PST ---
Created an attachment (id=63034)
 --> (https://bugs.webkit.org/attachment.cgi?id=63034)
Draft implementation #4

Greetings Eric,

Thank you for your review and comments.
I have added the AsyncSpellCheckerController class to encapsulate some spellchecker-specific code and apply your comments. (I may miss some of them, though.)

(In reply to comment #13)
> WebKit/mac/WebCoreSupport/WebEditorClient.mm:827
>  +  #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_6 && NS_BLOCKS_AVAILABLE
> NS_BLOCKS_AVAILABLE?

This define means we can use GCD (Grand Central Dispatch), which is required by [NSSpellChecker requestCheckingOfString:]. (Even though GCD is enabled by default on 10.6, we can disable it. So it may be safer to add this define in my code.)

It is definitely helpful to review the updated one and give me your comments?

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.