[Webkit-unassigned] [Bug 43166] InsertOrderedList does not switch the list type properly when it has an inner list.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43166


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62975|0                           |1
        is obsolete|                            |
  Attachment #62975|review?                     |
               Flag|                            |
  Attachment #63000|                            |review?
               Flag|                            |




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2010-07-29 15:26:28 PST ---
Created an attachment (id=63000)
 --> (https://bugs.webkit.org/attachment.cgi?id=63000)
made the call to endingSelection().firstRange().get() inline

(In reply to comment #4)
> > Mn.. but doesn't that lead to a memory leak since firstRange() returns a PassRefPtr?  Because I'm passing the same range object to multiple doApplyForSingleParagraph in the case of range selection, I don't really want doApplyForSingleParagraph to take PassRefPtr.
> 
> No, it does not lead to a memory leak. The PassRefPtr that is the result of the firstRange function goes out of scope after the function returns, and that's when it calls deref.

I see. Thanks for the clarification. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.