[Webkit-unassigned] [Bug 5864] feTurbulence is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5864


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62949|review?                     |review-
               Flag|                            |




--- Comment #29 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-29 13:57:09 PST ---
(From update of attachment 62949)
Hey Renata,

looks good to me, though I can't r+, as your patch contains unrelated changes to ResourceHandleMac.mm.

Two issues remaining:
WebCore/svg/graphics/filters/SVGFETurbulence.cpp:140
 +      seed = paintingSeed;
This is superflous, you're already initializing seed a few lines above.

WebCore/svg/graphics/filters/SVGFETurbulence.cpp:141
 +      filterSize = paintingSize;
Ditto.

Please upload a new version, and I'll r+ it. Can you commit on your own? If not, set cq? next time you upload.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.