[Webkit-unassigned] [Bug 42612] DRT should allow test scripts to access WebCore internal states for setup/verification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42612


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62805|review?                     |review-
               Flag|                            |




--- Comment #23 from Adam Barth <abarth at webkit.org>  2010-07-29 08:03:36 PST ---
(From update of attachment 62805)
WebCore/Configurations/FeatureDefines.xcconfig:47
 +  ENABLE_CORE_LAYOUT_TEST_CONTROLLER_Production = ;
I'm not sure this is a good approach.  Differences between Production and Release are bad because it means we're not testing the same thing we're shipping.  Also, it seems very likely that some port or other will get confused and ship WebCore::LTC to users.  I'm not sure what the consequences are today, but as it grows, I'm sure it will eventually be disaster.

Also, as a consequence, we won't be able to run these tests on production builds.  That means, we'll lose out on test coverage of the actual bits we ship.  There's got to be a better approach.

Here's a strawman proposal:

1) WebCore exports a C API for testing that consumed by a cross-platform layout test controller object that's build in a different project (DRT).

In that approach, we save the per-port hassle of adding features to LTC and we don't risk shipping those API to the web.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.