[Webkit-unassigned] [Bug 5864] feTurbulence is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5864


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62942|review?                     |review-
               Flag|                            |




--- Comment #26 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-29 06:48:50 PST ---
(From update of attachment 62942)
Sorry Renata, I missed some obvious issues before:
WebCore/svg/graphics/filters/SVGFETurbulence.cpp:131
 +  FETurbulence::PaintingData::PaintingData(long m_seed, IntSize filterSize)
You shouldn't name arguments passed to a struct with a m_. Use "long paintingSeed" and "const IntSize& paintingSize".

WebCore/svg/graphics/filters/SVGFETurbulence.cpp:134
 +      filterSize = filterSize;
Ouch! This can't work :-) I've no idea why this ever worked.

I'd suggest to initialize _all_ variables to be sure they are never read uninitialized:
FETurbulence::PaintingData::PaintingData(long paintingSeed, const IntSize& paintingSize)
    : seed(paintingSeed)
    , filterSize(paintingSize)
    , width(0)
    , height(0)
    , wrapX(0)
    , wrapY(0)
    , channel(0)
{
}

WebCore/svg/graphics/filters/SVGFETurbulence.h:34
 +      FETURBULENCE_TYPE_UNKNOWN      = 0,
We've stopped lining up these values, just remove the spaces inbetween:
FETURBULENCE_TYPE_UNKNOWN = 0,
..
WebCore/svg/graphics/filters/SVGFETurbulence.cpp:204
 +  float FETurbulence::noise2D(PaintingData& paintingData, FloatPoint noiseVector)
FloatPoint -> const FloatPoint&.

Okay, I hope these are the last problems, sorry for forcing you for yet another iteration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.