[Webkit-unassigned] [Bug 33668] WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33668





--- Comment #18 from Ojan Vafai <ojan at chromium.org>  2010-07-28 18:01:50 PST ---
(From update of attachment 62883)
>          Reviewed by Ojan Vafai.
> Index: LayoutTests/editing/execCommand/insert-list-orphaned-item-with-nested-lists-expected.txt
> ===================================================================
> --- LayoutTests/editing/execCommand/insert-list-orphaned-item-with-nested-lists-expected.txt	(revision 0)
> +++ LayoutTests/editing/execCommand/insert-list-orphaned-item-with-nested-lists-expected.txt	(revision 0)
> @@ -0,0 +1,23 @@
> +This tests hang when listifying nested lists with an orphaned list child in between (see bug 33668).
> +
> +<DIV id="test" contentEditable="">
> +<#text>
> +</#text>
> +<OL>
> +<UL>
> +<OL>
> +<LI>
> +<#text><selection-caret>hello</#text>
> +</LI>
> +</OL>
> +<#text>world</#text>
> +<OL>
> +<LI>
> +<#text>WebKit</#text>
> +</LI>
> +</OL>
> +</UL>
> +</OL>
> +<#text>
> +</#text>
> +</DIV>

This is OK for now since it's an improvement over the current behavior of hanging. :) Although, it would be more correct if that stray <UL> weren't there, right?

> +++ LayoutTests/editing/execCommand/5207369-expected.txt	(working copy)
> -<ul><li>One</li><li>Two</li><li>Three</li><li>Four</li></ul>
> +<ul><li>One</li><li>Two</li><ul><li>Three</li><li>Four</li></ul></ul>

Nice!

> +++ LayoutTests/editing/execCommand/create-list-from-range-selection-expected.txt	(working copy)
> @@ -16,6 +16,8 @@
>  <LI>
>  <#text>foo</#text>
>  </LI>
> +</OL>
> +<OL>
>  <LI>
>  <#text>bar</#text>
>  </LI>

This doesn't look right to me. Does this match what other browsers do? Firefox does something insane with this HTML. But I would expect the following DOM (the nested ordered list would stay nested):
<DIV id="test" contentEditable="true">
<OL>
<LI>
<#text>asd</#text>
<SPAN id="start">
<#text>fo<selection-anchor>o</#text>
</SPAN>
</LI>
<LI>
<#text>bar</#text>
</LI>
<LI>
<#text>baz</#text>
</LI>
<LI>
<#text>foo</#text>
</LI>
<OL>
<LI>
<#text>bar</#text>
</LI>
</OL>
<LI>
<#text>ba<selection-focus>z</#text>
</LI>
</OL>
</DIV>

Is my expectation wrong? What do Word/PowerPoint do?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.