[Webkit-unassigned] [Bug 43102] Set incorrect but close expectations for mask-colorspace.svg on mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 16:33:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43102





--- Comment #7 from Alex Nicolaou <anicolao at chromium.org>  2010-07-28 16:33:31 PST ---
(In reply to comment #6)
> (From update of attachment 62791 [details])
> (In reply to comment #2)
> > Is there a way to get layout test results automatically added to this bug by a bot? I am afraid the code change may affect the pixel results of a huge number of tests.
> 
> Sorry, I missed this comment. Setting back to r?.
> 
> The way you do this currently is to commit the patch and then grab the results off the bot. But, I'm confused now. Do you expect a lot of tests to change, if so, why did you include only the one set of new results in the patch?

I need to set up a leopard machine to rebaseline the tree because I only discovered today that I'm not allowed to rebaseline on snow leopard due to font rendering differences. I guess the right answer here is I need to set up a leopard mac to complete this patch, but in a perfect world there'd be a layout test bot that would run on the patch prior to submission. I also can't trust the commit queue because it isn't running all the tests.

FWIW this change is certainly more correct for Chromium/CG but the overhead of making it when my primary platform isn't mac is really high. I need to get myself set up better (it seems with four environments: linux, mac snow leopard, mac leopard, and windows).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list