[Webkit-unassigned] [Bug 33814] WebKitTools/Scripts/check-webkit-style gives false positives in single-line functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33814


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62831|review?                     |review+
               Flag|                            |




--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-07-28 12:30:57 PST ---
(From update of attachment 62831)
Looks great. I'll make the following changes when I'll land this patch.

WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2600
 +              '}\n',
I'd put a semicolon so this code is valid as C++.

WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2608
 +              '}\n',
ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.