[Webkit-unassigned] [Bug 43101] Using glMapTexSubImage2d in VideoLayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43101





--- Comment #2 from Andrew Scherkus <scherkus at chromium.org>  2010-07-28 11:02:30 PST ---
(From update of attachment 62789)
Few tiny nits... we'll probably need vangelis/darin to take a look.


WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:99
 +      // This is needed to get text to show up correctly. Without it,
indentation

WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:119
 +  #error "Need to implement for your platform."
Do you know if this will this break Chromium Mac since they don't use Skia?

WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:129
 +      ASSERT(skiaBitmap);
I think this will always be true since a reftype (const SkBitmap&) can't be NULL (it's sitting on your stack or in heap memory somewhere).  Therefore taking an address of that will always produce a non-NULL address.  Actually do we even need skiaBitmap?  It looks like you can do all operations in this function using bitmap.

WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:158
 +      ASSERT(skiaBitmap);
ditto for here

WebCore/platform/graphics/chromium/VideoLayerChromium.h:59
 +  
remove extra lines

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.