[Webkit-unassigned] [Bug 42603] Add a mock and LayoutTestController bindings for speech input.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42603





--- Comment #8 from Steve Block <steveblock at google.com>  2010-07-28 01:49:10 PST ---
Hi Satish,

I like the idea of a common mock in WebCore and providing common convenience wrappers in WebKit. A few comments.

- I still think that the decision of whether to use the mock or the real implementation should be left to the embedder, not handled by the WebKit layer. I think it's true to say that currently, all testing with LayoutTestController is done this way - implemented in the embedder only. This also avoids polluting WebKit with testing logic.

- For the WebKit mock wrapper, I like the Chromum-style approach of an interface in 'public' that replicates the WebCore interface and an impl in 'src' that implements both interfaces. It seems neater than the Mac-style approach of having a 'core()' function which returns the WebCore type being wrapped. One problem with this approach, however, is how to handle interfaces that use WebCore types as method arguments. For speech, this is not a problem, but DeviceOrientationClient, for example, has methods which use the WebCore DeviceOrientation type. The Chromium-style approach would require us to write wrappers for these types too, which means a lot of boilerplate. I guess we need to decide which is best overall.

- I'm not sure about the idea of using WebViewMocks to bundle together all the mocks. It seems like it assumes too much about how each platform wants to handle its mocks. I guess there's no requirement for a platform to use it, but I'm not sure it's useful.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.