[Webkit-unassigned] [Bug 42603] Add a mock and LayoutTestController bindings for speech input.

Tue Jul 27 07:14:18 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42603


--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-07-27 07:14:18 PST ---
(From update of attachment 62009)
LayoutTests/ChangeLog:33885
 +          * platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.che
This part of the diff looks strange.

LayoutTests/fast/forms/input-text-speechbutton.html:1
 +  <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
This doctype is very strange.

WebCore/Android.mk:385
 +      page/SpeechInputClientMock.cpp \
I'm not sure where the Mock file should go.  We have platform/mock, but this looks like a mock client...

WebKit/chromium/public/WebView.h:343
 +      virtual void setMockSpeechInputResult(const WebString& result) = 0;
This will require fishd review.

WebKit/mac/WebView/WebViewData.h:180
 +      OwnPtr<WebCore::SpeechInputClientMock> speechInputClientMock;
It's kind of lame that the mock object is owned by each port.  We don't have a good pattern established for these, so we might want to think about what will scale nicely to N mocks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.