[Webkit-unassigned] [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42827





--- Comment #12 from Johnny Ding <jnd at chromium.org>  2010-07-27 04:47:00 PST ---
(In reply to comment #11)
> 
> You're right that we use the dynamic frame for gestures, but we use the lexical frame for almost everything else.  Calling the dynamic frame the "active frame" is likely to confuse people into screwing up other uses.

I see, sorry for the confused wording, I will change it.

> I don't understand why we need these two APIs.  Can you explain why we need to make these distinctions?  It seems like clients just want to know if we're processing a user gesture.

If processingUserGesture is a instance method of ScriptController, it should reflect user gesture status of the owning Page and the caller should take responsibility to find the right Frame/ScriptController before calling the method. But unfortunately not every call follows this convention.
I saw that you and Yury had discussed this issues in https://bugs.webkit.org/show_bug.cgi?id=41350 before.

Like you suggest before, if we define processingUserGesture as a static member function of ScriptController, it makes sense to say it reflects whether WebKit is processing user gesture no matter which frame.
After searching all references of ScriptController::processingUserGesture in the WebCore, so far looks like every call of ScriptController::processingUserGesture just only wants to know whether WebKit is processing user gesture, they seems not to care which frame is processing.

Only thing we need to worry about is whether checking user gesture status of dynamic frame in ScriptController::processingUserGesture can cause regressions of bug 41350 & 41511. It's because the patches of those two bugs introduced the current issue. 

@Yury, According to the comments in crbug.com/44070, looks like the root cause of the bug 41350 was not directly related to getting the dynamic/entered frame in ScriptController::processingUserGesture. Are you OK with defining the function as static member function of ScriptController and checking the user gesture status of the dynamic/entered frame?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.