[Webkit-unassigned] [Bug 40374] Client-based Geolocation does not pass high power option to controller and client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40374


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jorlow at chromium.org




--- Comment #18 from Jeremy Orlow <jorlow at chromium.org>  2010-07-27 03:52:17 PST ---
(In reply to comment #17)
> > WebCore/page/GeolocationControllerClient.h:39
> >  +      // We should update the terminology used in WebCore to describe this property
> > Add FIXME
> OK, will do
> 
> > WebCore/page/GeolocationController.cpp:77
> >  +              m_client->setEnableHighAccuracy(false);
> > You said "done" but this (and above) didn't change.
> I removed the code which checked whether we were previously using high accuracy as an optimisation. I now call setEnableHighAccuracy(false) every time the list of high accuracy observers becomes empty. There's no way to avoid having this logic in the controller. The client doesn't know which observer requested high accuracy. This is tracked only in the controller, which then commands the client appropriately. The only alternative would be to move all this logic to the client, but that would lead to code replication across platforms.
> 
> > WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h:42
> >  +      void setEnableHighAccuracy(bool) { }
> > This should be the new terminology since it can't change easily once someone implements it.
> I don't think this is a good idea right now, as the future of the V2 spec isn't certain.

Ok and ok.  Will take another look soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.