[Webkit-unassigned] [Bug 40374] Client-based Geolocation does not pass high power option to controller and client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40374


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62583|review?                     |review-
               Flag|                            |




--- Comment #16 from Jeremy Orlow <jorlow at chromium.org>  2010-07-27 03:26:36 PST ---
(From update of attachment 62583)
WebCore/page/GeolocationControllerClient.h:39
 +      // We should update the terminology used in WebCore to describe this property
Add FIXME

WebCore/page/GeolocationController.cpp:77
 +              m_client->setEnableHighAccuracy(false);
You said "done" but this (and above) didn't change.

WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h:42
 +      void setEnableHighAccuracy(bool) { }
This should be the new terminology since it can't change easily once someone implements it.

WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h:45
 +      virtual void setEnableHighAccuracy(bool) { }
ditto

WebCore/page/GeolocationControllerClient.h:41
 +      // http://www.w3.org/2008/geolocation/track/issues/6
Maybe suggest that webkit ports implementing it call it "highPower"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.