[Webkit-unassigned] [Bug 40425] Web Inspector: provide API for content scripts to interact with the inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40425





--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-07-27 02:49:05 PST ---
(From update of attachment 62568)
I started it, but got distracted. Will continue a bit later.

WebCore/inspector/InspectorController.cpp:461
 +      if (m_scriptsToEvaluateOnLoad.size()) {
Why did this move? Looks fragile in case something depends on such a move internally.

WebCore/inspector/InspectorFrontendHost.cpp:195
 +  void InspectorFrontendHost::setExtensionAPI(const String& script)
Here and below: we should refer to extensions api as to plural. Also, we might want to make this functionality generic, no need to explicitly mention "extension" here.



WebCore/inspector/front-end/ElementsPanel.js:61
 +              WebInspector.extensionServer.notifyObjectSelected("elements", "DOMNode");
extensionsServer?

WebCore/inspector/front-end/ElementsPanel.js:61
 +              WebInspector.extensionServer.notifyObjectSelected("elements", "DOMNode");
What does "elements" stand for? Should it be a const?


WebCore/inspector/front-end/ExtensionAPI.js:31
 +  var extensionAPI = function(InjectedScriptHost, inspectedWindow, injectedScriptId)
extensionsAPI

WebCore/inspector/front-end/ExtensionAPI.js:31
 +  var extensionAPI = function(InjectedScriptHost, inspectedWindow, injectedScriptId)
This looks as if it is injected into the target page. You don't use InjectedScriptHost, inspectWindow and injectedScriptID, do you?

WebCore/inspector/front-end/ExtensionAPI.js:55
 +                  listeners[i] = listeners[listeners.length - 1];
splice?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.