[Webkit-unassigned] [Bug 42637] new-run-webkit-tests: Support auto indentation based on call stack depth for debugging

Tue Jul 27 01:12:53 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42637

--- Comment #9 from Hayato Ito <hayato at chromium.org>  2010-07-27 01:12:53 PST ---
Thank you for the comment.

(In reply to comment #7)
> (In reply to comment #6)
> 
> Hi Hayato, 
> 
> Thanks for posting the examples. After looking at them, indenting only the debugging statements looks goofy, so let's not do that.
> 
> One more change, though ... it looks like every print statement is being indented by some number of spaces (since there's probably a fixed size call stack 4-5 deep before any actual message), and that's just creating wasted whitespace (maybe 6-8 characters). It seems like maybe the correction for self.depth on line 147 of printing.py maybe isn't working right, or could be tweaked?

It would be difficult to know 'baseline' of stack depth.
I've tried to get it, but I am afraid that there is no way to tell that in confident. It is fragile value.
So we have to adapt an reasonable value as the baseline of stack depth, like 4 or 5 as you suggested. I'll modify it later.

> 
> As to annoying some people with the change to --verbose, some people will always be annoyed by any UI change; I don't think there's enough of them to justify the complexity of adding an additional switch, but if there is demand for one, we can add it in later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.